CSS 6730 - add ofga model tests #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
reviewed
Jun 20, 2024
alesstimec
reviewed
Jun 20, 2024
alesstimec
reviewed
Jun 20, 2024
alesstimec
approved these changes
Jun 20, 2024
babakks
approved these changes
Jun 21, 2024
kian99
reviewed
Jun 21, 2024
openfga/tests.fga.yaml
Outdated
Comment on lines
191
to
194
| - model:mo-1 | ||
| - model:mo-2 | ||
| writer: | ||
| - model:mo-1 |
There was a problem hiding this comment.
mo-1 is listed in both of these, but I see we only explicitly grant user:mo-1 admin access to model:mo-1. So I'm surprised it appears under both in list_objects. I need to go read the docs on what list_objects is doing
There was a problem hiding this comment.
It's because of this:
- user: user:*
relation: administrator
object: model:mo-2
list_objects checks whether the relations you've listed fully match those of a given object, that's why you need to list models accessible by everyone too.
…ator relation of serviceaccount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes tests that fully cover JIMM's authorisation model and ensure no breaking changes are introduced. Since OpenFGA doesn't have a procedure to alter existing models we need to verify the model behaves as expected, and that future changes to it don't break the intended behavior. It also adds the tests as a CI step.
Jira issue: CSS-6730
Engineering checklist